[v2] Controller Entrypoint #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To be rebased on top of #871 |
ian-shim
force-pushed
the
v2-controller
branch
from
e6a2d4f to
426c3cb
Compare
dmanc
reviewed
Nov 8, 2024
| Name: common.PrefixFlag(FlagPrefix, "available-relays"), | ||
| Usage: "List of available relays", | ||
| Required: true, | ||
| EnvVar: common.PrefixEnvVar(envVarPrefix, "AVAILABLE_RELAYS"), |
There was a problem hiding this comment.
How does this work? Each relay has a integer assigned to it?
There was a problem hiding this comment.
Yes, this will be a list of integer representing the disperser's relay keys
| } | ||
| NodeClientCacheSizeFlag = cli.IntFlag{ | ||
| Name: common.PrefixFlag(FlagPrefix, "node-client-cache-size"), | ||
| Usage: "Size of the node client cache", |
There was a problem hiding this comment.
Number of entries. Updated the name accordingly
ian-shim
force-pushed
the
v2-controller
branch
2 times, most recently
from
a8bc74f to
9f2a652
Compare
mooselumph
approved these changes
Nov 13, 2024
| dispatcherPool := workerpool.New(config.NumConcurrentDispersalRequests) | ||
| chainState := eth.NewChainState(chainReader, gethClient) | ||
| var ics core.IndexedChainState | ||
| if config.UseGraph { |
There was a problem hiding this comment.
What is the intention behind retaining the built-in indexer? Is this for testing purposes? Can we safely remove it?
There was a problem hiding this comment.
Yeah this is to support testing mode that doesn't use graph indexer.
I kept it because non-graph e2e tests have been useful few times in the past
ian-shim
force-pushed
the
v2-controller
branch
from
9f2a652 to
540efe4
Compare
ian-shim
force-pushed
the
v2-controller
branch
from
540efe4 to
d4f2faa
Compare
mooselumph
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Adds an entrypoint to controller that kicks off encoding manager and dispatcher.
TODO: dependency to encoding client to be resolved in follow up PR when #866 is merged
Checks